Re: [Xen-devel] [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

[Andrei Borzenkov <arvidjaar@xxxxxxxxx>]

29.10.2015 18:25, Vladimir 'Ï-coder/phcoder' Serbinenko ÐÐÑÐÑ:
> > +if [ "x$machine" != xaarch64 ]; then
> > +       multiboot_cmd="multiboot"
> > +       module_linux_cmd="module"
> > +       module_initrd_cmd="module --nounzip"
> > +else
> > +       multiboot_cmd="xen_hypervisor"
> > +       module_linux_cmd="xen_linux"
> > +       module_initrd_cmd="xen_initrd"
> > +fi
> > +
> Please do not hardcode an assumption that grub-mkconfig is executed on
> the same machine as GRUB is booted. I know that we have instances of
> such assumption in some cases but we'd like to eliminate them. Alternatives:
> - Check arch on boot time
This makes it even more difficult for os-prober to parse grub.cfg. We 
need some alternative before going this route.
> - Check that new xen commands are supported (define a new feature)
> Please add xen_* aliases on x86 as well
Yes, that's better.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel