Re: [Xen-devel] [PATCH] x86: make compat_iret() domain crash cases distinguishable

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/11/15 10:57, Jan Beulich wrote:
>>>> On 30.10.15 at 20:05, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 30/10/15 17:46, Jan Beulich wrote:
>>> Rather than issuing a (mostly) useless separate message, rely on
>>> domain_crash() providing enough data, and leverage the line number
>>> information it prints.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> The messages are not completely useless, and they do save a round-trip
>> to the debug symbols (which can be a very long RTT when dealing with
>> customers).
> Oh, also: Why would looking at the debug symbols be needed? You
> get file name and line number printed.

Any file patched will end up having a slide on the line number.  The use
of the debug symbols is necessary to confirm, especially in cases like
this where there are multiple possibilities close to each other.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel