[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xl: log an error if libxl_cpupool_destroy() fails

On Wed, 2015-10-28 at 16:51 +0000, Wei Liu wrote:
> On Wed, Oct 28, 2015 at 05:43:51PM +0100, Dario Faggioli wrote:
> > In fact, right now, failing at destroying a cpupool is just
> > not reported to the user in any explicit way.
> > 
> > Let's log an error, as it is customary for xl in these cases.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

This conflicted with the changes to use EXIT_(ERROR|SUCCESS). By changing
"return 0" into "return EXIT_SUCCESS" and "return 1" into "return
EXIT_ERROR" in the context it applied cleanly.Â

I was about to apply when I noticed the strange Reviewed-by: Jueregen
(having already spotted and fixed in the Cc). I don't think I want to apply
it like that. Please can you fix and rebase (after I push Harman's changes
soon) and resend.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.