[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] symbols.c: Avoid warn_unused_result build failure on fgets().

On Wed, 2015-11-04 at 13:39 +0200, Riku Voipio wrote:

Not to do with this patch (and this suggestion wouldn't have helped in this
case) but IIRC Linaro tests the xen.git#staging branch.

We recently introduced a new "smoke test" phase which is a quick[0] test
which runs on staging before the regular big test runs to check for obvious
errors, build problems, simple guest booting etc.

The sequence of tests on xen's development branch is now:
 * A committer pushes to xen.git#staging
 * osstest runs smoke tests on staging and propagates passes to
 * osstest runs full suite of tests tests on smoked and propagates passes
   to xen.git#master

I mention this because perhaps Linaro would want to switch to running their
tests on #smoked instead of #staging, and avoid the cases where things are
completely knackered?

In this case the compiler which osstest uses apparently doesn't warn about
fgets() not being checked, so it wouldn't actually have helped...


[0] ~2 hours turnaround, compared with a day or more for regular test

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.