Re: [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.11.15 at 08:55, <zhaoshenglong@xxxxxxxxxx> wrote:
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -636,8 +636,8 @@ static void __init efi_console_set_mode(void)
>  static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void)
>  {
>      EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info;
> -    EFI_GRAPHICS_OUTPUT_PROTOCOL *gop;
> -    EFI_HANDLE *handles;
> +    EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
> +    EFI_HANDLE *handles = NULL;

I can see the issue with handles being left uninitialized, but if you
think gop also needs initializing, then I would have expected an
explanation. The change is simple enough to take as is, but in the
future please explain changes that aren't obviously needed.

Also please Cc maintainers for the touched code on your patches.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel