Re: [Xen-devel] ovmf fail to compile

["Hao, Xudong" <xudong.hao@xxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: Friday, November 6, 2015 6:24 PM
> To: Hao, Xudong <xudong.hao@xxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] ovmf fail to compile
> 
> On Fri, Nov 06, 2015 at 08:53:27AM +0000, Hao, Xudong wrote:
> > > -----Original Message-----
> > > From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> > > Sent: Wednesday, November 4, 2015 6:19 PM
> > > To: Hao, Xudong <xudong.hao@xxxxxxxxx>
> > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxx
> > > Subject: Re: [Xen-devel] ovmf fail to compile
> > >
> > > On Wed, Nov 04, 2015 at 08:27:56AM +0000, Hao, Xudong wrote:
> > > > "git clean -fdx" doesn't change the error result with gcc 4.4.7.
> > > > Gcc version is
> > > "gcc-4.4.?" in Debian Jessie of yours?
> > > >
> > >
> > > Debian Jessie's gcc-4.4 has the same version 4.4.7.
> > >
> > > As the other sub-thread suggests, can you try passing more f's to git?
> > >
> >
> > After more f's (git clean -ffffddddxxxx), still met same compile issue.
> >
> > > A somewhat related question, are you only interested in xen-unstable 
> > > branch?
> > > Have you tried latest OVMF from upstream? If that builds for you I
> > > can easily send another patch to update Config.mk again.
> > >
> >
> > Checked the upstream OVMF (git://git.code.sf.net/p/tianocore/edk2), the
> compile issue persist with gcc 4.4.7. Maybe I can raise it to EDKII community.
> 
> Right. Looks like this is an issue in upstream.
> 
> Thanks for your investigation.
> 

Wei, 

Can you update Config.mk? edk2 upstream had fix for this issue after raising 
issue out.

commit 67b3c0f95886a478c4fd3d6f48489dbc7aee9818
Author: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
Date:   Mon Nov 9 08:39:28 2015 +0000

    BaseTools GCC: move PECOFF_HEADER_SIZE definition before LD script

    Older versions of binutils need all symbols to be defined when consuming
    the linker script passed via the command line. So move the definition
    '--defsym=PECOFF_HEADER_SIZE=...' before the '--script=...' command line
    argument.

    Contributed-under: TianoCore Contribution Agreement 1.0
    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
    Reviewed-by: Liming Gao <liming.gao@xxxxxxxxx>

    git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18747 
6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/BaseTools/Conf/tools_def.template 
b/BaseTools/Conf/tools_def.template
index 1fef6af..db08e25 100644
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -3844,9 +3844,9 @@ DEFINE GCC44_X64_CC_FLAGS            = 
DEF(GCC44_ALL_CC_FLAGS) -m64 -fno-stack-p
 DEFINE GCC44_IA32_X64_DLINK_COMMON   = -nostdlib -n -q --gc-sections -z 
common-page-size=0x20
 DEFINE GCC44_IA32_X64_ASLDLINK_FLAGS = DEF(GCC44_IA32_X64_DLINK_COMMON) 
--entry ReferenceAcpiTable -u ReferenceAcpiTable
 DEFINE GCC44_IA32_X64_DLINK_FLAGS    = DEF(GCC44_IA32_X64_DLINK_COMMON) 
--entry $(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Map 
$(DEST_DIR_DEBUG)/$(BASE_NAME).map
-DEFINE GCC44_IA32_DLINK2_FLAGS       = DEF(GCC_DLINK2_FLAGS_COMMON) 
--defsym=PECOFF_HEADER_SIZE=0x220
+DEFINE GCC44_IA32_DLINK2_FLAGS       = --defsym=PECOFF_HEADER_SIZE=0x220 
DEF(GCC_DLINK2_FLAGS_COMMON)
 DEFINE GCC44_X64_DLINK_FLAGS         = DEF(GCC44_IA32_X64_DLINK_FLAGS)  
-melf_x86_64 --oformat=elf64-x86-64
-DEFINE GCC44_X64_DLINK2_FLAGS        = DEF(GCC_DLINK2_FLAGS_COMMON) 
--defsym=PECOFF_HEADER_SIZE=0x228
+DEFINE GCC44_X64_DLINK2_FLAGS        = --defsym=PECOFF_HEADER_SIZE=0x228 
DEF(GCC_DLINK2_FLAGS_COMMON)
 DEFINE GCC44_ASM_FLAGS               = DEF(GCC_ASM_FLAGS)

 DEFINE GCC45_IA32_CC_FLAGS           = DEF(GCC44_IA32_CC_FLAGS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel