Re: [Xen-devel] [PATCHv2] 26/27] build: convert CONFIG_COMPAT to Kconfig

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/11/15 16:50, Doug Goldstein wrote:
> Use the Kconfig generated CONFIG_COMPAT defines in the code base.
>
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>

(As a note - you appear to have double S-o-B in all patches)

> ---
>  xen/arch/x86/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index c8627cb..6cd22cc 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -25,6 +25,13 @@ config ARCH_DEFCONFIG
>  
>  menu "Architecture Features"
>  
> +config COMPAT
> +     bool "32-bit PV support"
> +     default y
> +     help
> +       Support 32-bit PV guests on 64-bit Xen
> +
> +       If unsure, say Y.
>  endmenu
>  
>  source "common/Kconfig"

COMPAT is actually the 32bit interface support on 64bit Xen, and applies
equally to 32bit HVM guests.  It is an overly large bucket which should
be disentangled moving forwards.

It is (sadly) mandatory for HVM guests, as HVMLoader makes 32bit
hypercalls irrespective of the destination runmode of the guest.

For now, I would just word this as "32-bit Interface support".

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel