[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 3/6] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

On 13/11/15 15:05, Stefano Stabellini wrote:
> On Fri, 13 Nov 2015, Julien Grall wrote:
>> On 13/11/15 14:37, Stefano Stabellini wrote:
>>> On Mon, 9 Nov 2015, Julien Grall wrote:
>>>> +    for ( i = 0; i < NR_TARGETS_PER_ITARGETSR; i++, offset++, virq++ )
>>> offset is not needed in the loop
>> offset is used in patch #4. Until v3, this patch was melted in patch #4
>> and by mistake I move the change here.
>> So all the changes, the 3 lines above + this one, are valid after the
>> patch #4.
>> Given that I don't expect much changes in this version, I won't bother
>> to rework it for this minor and harmless changes.
> Each patch should stand on its own. What if a week from now we want to
> revert patch #4 because it causes regressions?

Well you will have a pointless variable incremented. But that's harmless.

However, you won't be able to easily revert patch #4 as the follow-up
patches relies on it.

TBH, I'm surprised that you are complaining about a meaningless change
while ugly (and unavoidable) code as been acked without a single remark
(see patch #2).

I'm not plan to resend the whole series for only this change. But feel
free to do it yourself.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.