Re: [Xen-devel] [RFC PATCH 6/6] libxl: create path for advertisement of network attributes...

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("[RFC PATCH 6/6] libxl: create path for advertisement of 
network attributes..."):
> -    frontend_perms[0].id = device->domid;
> -    frontend_perms[0].perms = XS_PERM_NONE;
> -    frontend_perms[1].id = device->backend_domid;
> -    frontend_perms[1].perms = XS_PERM_READ;
> +    attr_perms[0].id = frontend_perms[0].id = device->domid;
> +    attr_perms[0].perms = frontend_perms[0].perms = XS_PERM_NONE;
> +    attr_perms[1].id = frontend_perms[1].id = device->backend_domid;
> +    attr_perms[1].perms = frontend_perms[1].perms = XS_PERM_READ;

Why not just use frontend_perms throughout rather than creating a new
identical structure ?

If you do want another structure, please line up the assignemnts
horizontally so that it is easy to read !

Also there is a lot of wrap damage in this patch.  Can you please
rewrap the lines you touch, at least ?  At the moment it is hard for
me to read.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel