[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 1/6] x86/intel_pstate: add some calculation related support

To: "Wei Wang" <wei.w.wang@xxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Tue, 17 Nov 2015 10:36:09 -0700
Cc: andrew.cooper3@xxxxxxxxxx, wei.liu2@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxx
Delivery-date: Tue, 17 Nov 2015 17:36:19 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>> On 28.10.15 at 04:21, <wei.w.wang@xxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/div64.h
> +++ b/xen/include/asm-x86/div64.h

Considering you don't even do this in common code, why did you pick
the BITS_PER_LONG == 32 variants from Linux? Would make for
quite a bit smaller a patch and quite a bit better easier to read code.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Prev by Date: Re: [Xen-devel] [PATCH v11 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops
Next by Date: Re: [Xen-devel] [PATCH 2/2] grant_table: convert grant table rwlock to percpu rwlock
Previous by thread: [Xen-devel] [PATCH OSSTEST 0/5] make-flight job filter cleanups
Next by thread: [Xen-devel] Fwd: Question regarding the behavior of guest_physmap_remove_page on x86
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.