Re: [Xen-devel] [PATCH v3 1/4] xen/save: pass a size parameter to the HVM compat functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.11.15 at 17:37, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/hvm/save.h
> +++ b/xen/include/xen/hvm/save.h
> @@ -60,6 +60,8 @@ void _hvm_read_entry(struct hvm_domain_context *h,
>   */
>  #define _hvm_load_entry(_x, _h, _dst, _strict) ({                       \
>      int r;                                                              \
> +    struct hvm_save_descriptor *d                                       \
> +        = (struct hvm_save_descriptor *)&(_h)->data[(_h)->cur];         \

This would seem to belong in the else if() body below. Also I
don't think "d" is a suitable name for a variable inside a macro
(albeit the same would apply to "r" too).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel