[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 0/9] xen: build fixes with gcc5 and binutils 2.25.0

From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>

Here's a slew of build fixes as well as build warning fixes
required when using the latest build tools, at least gcc 5 and
binutils 2.25.0. I ran into this while doing development on OpenSUSE
factory. Other rolling distros seem to be having similar issues based
on inspection of recent patches.

After fixing the issue I looked into the respective upstream
projects where are appropriate and provided annotations for
respective upstream fixes. The patches that have a respective upstream
project but do not have upstream annotations lack the annotations are
upstream code has already changed considerably and the patches do not
apply or the code has already been fixed but the respective upstream
atomic fix does not apply to our code branch. That said then, there is
no need to send anything to our usptream. My changes actually do have
a bit better annotations for some fixes than upstream, specifically
where I see a change fixed an issue I explain the actual issue that
should have been caused without the patch. That should make it easier
to evaluate integration of the patches into a stable branch or not.

Since some patches are part of upstream you could just consider
bumping upstream, or pulling the respective patch from upstream,
some of my annotations however have a bit better explanation for
why we wnat the changes. For stable branches these could be considere
as backport fixes. Up to you to decide how you want to manage these

I've build tested this on both the xen master branch and the
xen stable-4.6 branch, so feel free to consider some of these into
stable-4.6 if its desirable to build Xen with the latest and greatest gcc
and binutils. I've only run time tested the master branch of Xen
on dom0 with these changes.

Changes are required on a slew of different trees. The order of the
patches match the order in which I found the issues and fixed them,
the summary of the changes for each different tree is below.

These following patches just fix warnings and as such are not required to
complete proper building, but they seem worthy enough at least for
consideration on unstable:

  hw/usb-net.c: fix state check
  qemu-xen-dir: virtio-rng: fix check for period_ms validity
  mini-os: fix linker warning with app.lds
  vtpm: fix vtpmblk.c compilation warning
  vtpm: guard against redefining TPM_VENDOR_COMMAND

The rest are definitely needed for proper building.

The gnutls fix goes with a Coccinelle rule file which should enable
proper transformation of the needed changes in other projects, so
long as the code matches in form. The Coccinelle rule file changes
can also enable the same patch to be easily rebased should the code
change in between the patch being considered for merging which would
otherwise cause a legacy patch conflict.


Luis R. Rodriguez (1):
  Revert "Use the extra stack for 16bit USB and PS2 keyboard/mouse commands."

 src/kbd.c   | 6 +++---                                                         
 src/mouse.c | 6 +++---                                                         
 2 files changed, 6 insertions(+), 6 deletions(-)  

Luis R. Rodriguez (2):
  Use gnutls_priority_set_direct() to deprecate gnutls_*_set()
  hw/usb-net.c: fix state check

 hw/usb-net.c |  4 ++--
 vnc.c        | 21 +--------------------
 2 files changed, 3 insertions(+), 22 deletions(-)

Luis R. Rodriguez (2):
  qemu-xen-dir: avoid using spice-experimental.h
  qemu-xen-dir: virtio-rng: fix check for period_ms validity

 hw/virtio/virtio-rng.c | 2 +-
 spice-qemu-char.c      | 1 -
 ui/spice-core.c        | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

Luis R. Rodriguez (1):
  mini-os: fix linker warning with app.lds

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Top level xen git tree on stubdom/

Luis R. Rodriguez (3):
  stubdom: fix unfound libgmp library issues
  vtpm: fix vtpmblk.c compilation warning
  vtpm: guard against redefining TPM_VENDOR_COMMAND

 stubdom/Makefile               | 5 +++++
 stubdom/vtpm/vtpmblk.c         | 1 +
 stubdom/vtpmmgr/vtpm_manager.h | 3 +++
 3 files changed, 9 insertions(+)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.