Re: [Xen-devel] [PATCH OSSTEST v2] Add $gho->{Suite} field to guest objects from {prepare, select}guest()

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-11-23 at 16:12 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2] Add $gho->{Suite} field to guest
> objects from {prepare,select}guest()"):
> > Currently those places which want this open code a lookup of the
> > {ident}_suite runvar with a fallback to the configuration file.
> > 
> > However selecthost was missing such a lookup in the case where it is
> > constructing a nested L1 host (which begins from the selectguest
> > template), which lead to ts-xen-install on Jessie missing the
> > installation of libnl-route-3-200.
> > 
> > Fix this by having prepareguest() store a {ident}_suite runvar (taking
> > care to handle the case where one is already set by e.g. make-flight)
> > and have selectguest() initialise $gho->Suite from it.
> 
> Having thought about this, ISTM that this will cause strangenesses
> such as runvars called `redhat_suite' with value `jessie' (or
> whatever).
> 
> Perhaps ts-debian*install could call some new function
> debian_guest_suite in Debian.pm ?

Sure. Should it return the suite (to be put into $gho->{Suite} by the
caller) or initialise $gho->{Suite} itself? I lean towards the latter.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel