[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 0/6] xen: sched: fix locking of {insert, remove}_vcpu()

If I can jump in the conversion...

2015-11-23 10:00 GMT-05:00 Jan Beulich <JBeulich@xxxxxxxx>:
>>>> On 23.11.15 at 15:50, <george.dunlap@xxxxxxxxxx> wrote:
>> On 23/11/15 14:40, Jan Beulich wrote:
>>>>>> On 23.11.15 at 15:03, <George.Dunlap@xxxxxxxxxxxxx> wrote:
>>>>> ---
>>>>> Dario Faggioli (6):
>>>>>       xen: sched: fix locking of remove_vcpu() in credit1
>>>>>       xen: sched: fix locking for insert_vcpu() in credit1 and RTDS
>>>>>       xen: sched: clarify use cases of schedule_cpu_switch()
>>>>>       xen: sched: better handle (not) inserting idle vCPUs in runqueues
>>>>>       xen: sched: get rid of the per domain vCPU list in RTDS
>>>>>       xen: sched: get rid of the per domain vCPU list in Credit2
>>>> Committers,
>>>> It looks to me like this series has all the Acks and Reviews it needs
>>>> to be checked in, but (as far as I can see) hasn't yet.  Can someone
>>>> double-check and check it in?  (See the git tree above if you want to
>>>> make it easier.)
>>> I've been waiting for an ack on patch 2 (and I've just checked again
>>> and still can't find any); with this diffstat
>>>  xen/common/sched_credit.c |    6 ++++++
>>>  xen/common/sched_rt.c     |    3 +++
>>>  xen/common/schedule.c     |    6 ++----
>>> Meng's alone isn't sufficient afaict. I've once made an attempt to
>>> commit later patches in this series, but failed and then didn't want
>>> to waste time retrying.

Hmm, I can help do some quick tests on the patch. At least, make sure
it has no problem in applying on the latest commit point.

>> What are the rules again, then?  Dario is a scheduler maintainer, and
>> Meng is an established contributor.  I thought that was enough.
> My understanding is that patches by maintainers need an ack
> by another maintainer as long as there is one. When there's
> none, things become more fuzzy.

I think George is the maintainer for the whole scheduler. If George
could ack, it may be enough?



Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.