Re: [Xen-devel] [V12 1/4] x86/xsaves: using named operand instead numbered operand in xrstor

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.11.15 at 08:51, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/xstate.c
> +++ b/xen/arch/x86/xstate.c
> @@ -158,6 +158,16 @@ void xsave(struct vcpu *v, uint64_t mask)
>          ptr->fpu_sse.x[FPU_WORD_SIZE_OFFSET] = word_size;
>  }
>  
> +#define XRSTOR_FIXUP   ".section .fixup,\"ax\"           \n"    \
> +                       "2: mov %[size],%%ecx             \n"    \
> +                       "   xor %[lmask_out],%[lmask_out] \n"    \
> +                       "   rep stosb                     \n"    \
> +                       "   lea %[mem],%[ptr]             \n"    \
> +                       "   mov %[lmask_in],%[lmask_out]  \n"    \
> +                       "   jmp 1b                        \n"    \
> +                       ".previous                        \n"    \
> +                       _ASM_EXTABLE(1b, 2b)

So this is exactly the disconnect I told you to avoid: The definition
here and the use site can't independently change any of the
operand names, since you don't pass them as macro arguments.
But I guess I'll give up on this an will try to remember to adjust this
later myself.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel