[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/boot: check for not allowed sections before linking

>>> On 25.11.15 at 13:43, <daniel.kiper@xxxxxxxxxx> wrote:
> Currently check for not allowed sections is performed just after
> compilation. However, if compilation succeeds and check fails then
> second build will create xen.gz/xen.efi without any visible error.
> This happens because %.o: %.c recipe created object file during first
> run and make do not execute this recipe during second run. So, look
> for not allowed sections before linking. This way check will be
> executed every time.

Good catch. Generally we'd want to not defer such checks to the
linking stage, but for the specific case here this seems quite okay
(and the alternative of going through a temporary file would seem
more cumbersome).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.