[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote:
> The use of $(basename ...) here was wrong (yet I'm sure I tested it).

Is the issue here thatÂxen/arch/x86/x86_64/.compat.o.d ought really to be

Otherwise xen/arch/x86/Makefile (which contains obj-y := ...
x86_64/compat.o) does not correctly track the dependencies of that file?

But that being the case I'm then confused, since it doesn't seem that the
currently wrong version is missing the .o or anything like that which is
what I would have expected the basename to be doing.

This is all in a recently built x86_64 tree (the one I used when building
before push earlier today).

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -105,7 +105,7 @@ include Makefile
> ÂDEPS = .*.d
> Âdefine gendep
> ÂÂÂÂÂifneq ($(1),$(subst /,:,$(1)))
> -ÂÂÂÂÂÂÂÂDEPS += $(dir $(1)).$(basename $(notdir $(1))).d
> +ÂÂÂÂÂÂÂÂDEPS += $(dir $(1)).$(notdir $(1)).d
> ÂÂÂÂÂendif
> Âendef
> Â$(foreach o,$(filter-out %/,$(obj-y)),$(eval $(call gendep,$(o))))

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.