[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] x86/cpu: Introduce cpu_dev.c_early_init()

>>> On 26.11.15 at 17:58, <andrew.cooper3@xxxxxxxxxx> wrote:
> The name is chosen to be consistent with Linux.  Doing this allows
> early_intel_workaround() to be removed from common code.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one adjustment suggestion (which I'll do on commit unless you

> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -156,10 +156,8 @@ static void __devinit set_cpuidmask(const struct 
> cpuinfo_x86 *c)
>       }
>  }
> -void __devinit early_intel_workaround(struct cpuinfo_x86 *c)
> +static void __devinit early_init_intel(struct cpuinfo_x86 *c)

The __devinit should be dropped here considering that we mean
to drop them gradually anyway.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.