[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Be more careful with error handling in libxl__dm_runas_helper()

On Thu, 2015-11-26 at 17:47 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: Be more careful with
> error handling in libxl__dm_runas_helper()"):
> > On Thu, 2015-11-26 at 10:03 +0000, Ian Campbell wrote:
> > > My reference when reviewing this is the (IMHO more canonical)Âhttp://
> > > pubs.o
> > > pengroup.org/onlinepubs/9699919799/functions/getpwnam.htmlÂ.
> > 
> > Maybe we should be considering whether "Applications wishing to check
> > for
> > error situations should set errno to 0 before calling getpwnam(). If
> > getpwnam() returns a null pointer and errno is non-zero, an error
> > occurred." ought to be applies to getpwnam_r too?
> Maybe that is the bug in the OS Boris is having this trouble with.ÂÂIf
> so then setting errno first would be a better workaround.

I can certainly imagine that easily happening, I misread the description in
the link above in exactly this way myself when I first started reviewing
Stefano's original patch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.