Re: [Xen-devel] [OSSTEST PATCH] sg-run-job: Coalesce a couple of repetitions

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-11-27 at 16:54 +0000, Ian Jackson wrote:
> Fold `guest-localmigrate.2' into `guest-localmigrate/x10' and
> `guest-start.2' into `guest-start.repeat'.ÂÂIn each case increase the
> iteration count of the 2nd test by one so that the total number of
> reps remains constant.
> 
> This will allow the heisenbug compensator to see more of these
> failures as the same failures.
> 
> The resulting testid `guest-localmigrate/x10' becomes a bit misleading
> in that it now does 11 repetitions.ÂÂBut we don't want to change the
> testid.

I'd be inclined to just accept the possibility of missing a failure on the
11th iteration and just do 10 instead of 10+1.


> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> Âsg-run-job |ÂÂÂÂ8 ++------
> Â1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/sg-run-job b/sg-run-job
> index 4f6b43a..a74d638 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -374,10 +374,7 @@ proc test-guest-migr {g} {
> Â     run-ts . =.2 ts-guest-saverestore + host $g
> ÂÂÂÂÂ}
> ÂÂÂÂÂif {$can_migrate} {
> -ÂÂÂÂÂÂÂÂrun-ts . =.2 ts-guest-localmigrate + host $g
> -ÂÂÂÂ}
> -ÂÂÂÂif {$can_migrate} {
> -ÂÂÂÂÂÂÂÂrun-ts . = ts-guest-localmigrate x10 + host $g
> +ÂÂÂÂÂÂÂÂrun-ts . =/x10 ts-guest-localmigrate + x11 host $g
> ÂÂÂÂÂ}
> Â}
> Â
> @@ -388,9 +385,8 @@ proc test-guest {g} {
> Â
> Âproc test-guest-nomigr {g} {
> ÂÂÂÂÂrun-ts . =ÂÂÂts-guest-stopÂÂÂÂ+ host $g
> -ÂÂÂÂrun-ts . =.2 ts-guest-startÂÂÂ+ host $g
> Â
> -ÂÂÂÂrepeat-ts 10 =.repeat \
> +ÂÂÂÂrepeat-ts 11 =.repeat \

When this repeat starts the guest is now stopped, whereas before it was
running. Does the body of the loop, which starts with a ts-guest-stop,
handle that?

Maybe you should remove the ts-guest-stop right at the start of this fn
too?

> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ+ ts-guest-stopÂÂÂÂhostÂÂÂ$g \; \
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ+ ts-guest-start + host + $g +
> Â

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel