[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH OSSTEST] ts-debian-di-install: Don't set runvars for netboot kernel+ramdisk as outputs

Currently these runvars are either URLs provided by the definition
(e.g. make-flight) or output controller-relative paths created by the
execution (in the case where they aren't from the definition).

This wierd dual-semantics is confusing and wrong, and in particular is
broken if the test step is rerun (e.g. in standalone mode).

In the case where they are outputs only  these paths is information
only. The information is already available in the full logs so
dropping the runvars here merely removes the information from the
summary table. It's not so useful that this is an issue.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
 ts-debian-di-install | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ts-debian-di-install b/ts-debian-di-install
index a9b3b20..96acd0e 100755
--- a/ts-debian-di-install
+++ b/ts-debian-di-install
@@ -163,9 +163,6 @@ sub setup_netboot($$$)
        target_putfile_root($ho, 60, $kernel, "$didir/kernel_${suite}_${arch}");
        target_putfile_root($ho, 60, $ramdisk, 
-       store_runvar("$gho->{Guest}_netboot_kernel", $kernel);
-       store_runvar("$gho->{Guest}_netboot_ramdisk", $ramdisk);
     return <<END;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.