Re: [Xen-devel] [PATCH v3] x86/VPMU: implement ipc and arch filter flags

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 11/25/2015 08:02 PM, Brendan Gregg wrote:
> This introduces a way to have a restricted VPMU, by specifying one of two
> predefined groups of PMCs to make available. For secure environments, this
> allows the VPMU to be used without needing to enable all PMCs.
>
> Signed-off-by: Brendan Gregg <bgregg@xxxxxxxxxxx>
> ---
> Changes in v3:
> * addressing review comments from Boris:
> * ensure final flag is validated
> * code tidy
>
> Changes in v2:
> * feature flags can now be combined (eg, "vpmu=ipc,bts")
> * addressing review comments from Boris:
> * restrict DS_AREA and PEBS_ENABLE access when filters are in use
> * better variable types
> * include MSR_IA32_CMT_EVTSEL_UE_MASK flag
> ---
>   docs/misc/xen-command-line.markdown | 14 +++++++++-
>   xen/arch/x86/cpu/vpmu.c             | 51 +++++++++++++++++++++++++++++--------
>   xen/arch/x86/cpu/vpmu_intel.c       | 49 +++++++++++++++++++++++++++++++++++
>   xen/include/asm-x86/msr-index.h     |  1 +
>   xen/include/public/pmu.h            | 14 ++++++++--

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel