[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] build: fix clean rule to cover objects in unvisited subdirs

>>> On 30.11.15 at 18:29, <jonathan.creekmore@xxxxxxxxx> wrote:
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -173,7 +173,7 @@ FORCE:
>  .PHONY: clean
>  clean:: $(addprefix _clean_, $(subdir-all))
> -     rm -f *.o *~ core $(DEPS)
> +     rm -f *.o *~ core $(DEPS) $(obj-y)

While for the moment it would do, using a minimalistic approach
like this will make us touch this again the moment we gain files in
subdirectories that can be built just optionally. At the very least
I'd therefore suggest also adding $(obj-n) and $(obj-) here. It
might even be reasonable to grab subdirectories from $(obj-...)
and add $(foreach d,$(filtered-subdirs), $(d)/*.o). Or, completely
differently, have xen/common/Makefile just have an add-on
clean:: (and require this also for future other cases like this).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.