Re: [Xen-devel] [PATCHv3] 1/3] libxc: prefer using privcmd character device

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-12-02 at 11:42 +0000, Wei Liu wrote:
> On Tue, Dec 01, 2015 at 01:27:53PM -0600, Doug Goldstein wrote:
> > Prefer using the character device over the proc file if the character
> > device exists. This follows similar conversions of xenbus to avoid
> > issues with FMODE_ATOMIC_POS added in Linux 3.14 and newer.
> > 
> > CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I believe this version also satisfies Ian's comments on v1, so I've applied
all 3 patches.

NB the extra "]" in the subject meant git am produced things like "1/3]
libxc: prefer using privcmd character device". I've fixed that up.

> 
> > ---
> > Âtools/libxc/xc_linux_osdep.c | 8 +++++++-
> > Â1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/libxc/xc_linux_osdep.c
> > b/tools/libxc/xc_linux_osdep.c
> > index 76c55ff..c3a3a14 100644
> > --- a/tools/libxc/xc_linux_osdep.c
> > +++ b/tools/libxc/xc_linux_osdep.c
> > @@ -46,7 +46,13 @@
> > Âstatic xc_osdep_handle linux_privcmd_open(xc_interface *xch)
> > Â{
> > ÂÂÂÂÂint flags, saved_errno;
> > -ÂÂÂÂint fd = open("/proc/xen/privcmd", O_RDWR);
> > +ÂÂÂÂint fd = open("/dev/xen/privcmd", O_RDWR); /* prefer this newer
> > interface */
> > +
> > +ÂÂÂÂif ( fd == -1 && ( errno == ENOENT || errno == ENXIO || errno ==
> > ENODEV ))
> > +ÂÂÂÂ{
> > +ÂÂÂÂÂÂÂÂ/* Fallback to /proc/xen/privcmd */
> > +ÂÂÂÂÂÂÂÂfd = open("/proc/xen/privcmd", O_RDWR);
> > +ÂÂÂÂ}
> > Â
> > ÂÂÂÂÂif ( fd == -1 )
> > ÂÂÂÂÂ{

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel