Re: [Xen-devel] [PATCHv6] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 11/30/15 8:50 AM, Jan Beulich wrote:
>>>> On 24.11.15 at 18:51, <cardoe@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -3,6 +3,7 @@ config X86_64
>>  
>>  config X86
>>      def_bool y
>> +    select HAS_PASSTHROUGH
>>      select HAS_GDBSX
> 
> Please get these sorted alphabetically from the beginning.
> 
>> --- /dev/null
>> +++ b/xen/drivers/passthrough/Kconfig
>> @@ -0,0 +1,4 @@
>> +
>> +# Select HAS_PASSTHROUGH if PCI pass through is supported
>> +config HAS_PASSTHROUGH
>> +    bool
> 
> s/PCI/device/ in the comment please.
> 
>> @@ -348,9 +348,9 @@ static XSM_INLINE int 
>> xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, uint
>>      return xsm_default_action(action, current->domain, d);
>>  }
>>  
>> -#endif /* HAS_PASSTHROUGH && HAS_PCI */
>> +#endif /* CONFIG_HAS_PASSTHROUGH && HAS_PCI */
> 
> I don't think fiddling with trailing comments like this one is really
> useful - the connection is clear also without CONFIG_ prefix.
> 
> Jan
> 

Most of this series was mechanical early on (e.g. sed). I can
selectively undo updating the comments if that's desirable.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel