[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH 11/11] mg-schema-test-database: Sort out daemons; provide `daemons' subcommand

On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> We arrange for the test configuration to look for the daemons on a
> different host and port, and we provide a convenient way to run such a
> pair of daemons.

I was missing where *Daemon{Host,Port} were set here, it turns out to be in
patch 9, which might be a bisection issue? I'm not sure we care for this
new code.

It also occurred to me while reading this that I didn't know what to do
with OSSTEST_CONFIG here, I've not spotted in patch 9 where withtest()
behaves in the obvious way, but it might be worth mentioning explicitly in
the comments that the script DTRT and it is never(/rarely) necessary to set
OSSTEST_CONFIG=local-config.test-database_SUFFIX yourself.

But that's a comment on a previous patch, so:

> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.