[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] efi: mark input variables to funcs as const

>>> On 05.12.15 at 21:25, <cardoe@xxxxxxxxxx> wrote:
> Variables that are input (IN) variables to EFI functions should be
> marked as const. Just avoid potential problems of changing data that
> shouldn't be changed.

I don't think this is correct (there's no reason for a function to not
use its input arguments as variables), and it certainly should come
from upstream (i.e. UEFI -> gnu-efi -> Xen) if really meant to be
done this way. Also I think if you want this for debugging purposes,
overriding IN, OUT, and OPTIONAL in the source file(s) as intended
by the surrounding #ifdef would be the way to go.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.