Re: [Xen-devel] [OSSTEST PATCH 06/11] cri-getconfig: Provide get_psql_cmd and get_pgdump_cmd

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 06/11] cri-getconfig: Provide 
get_psql_cmd and get_pgdump_cmd"):
> On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> > +get_psql_cmd () {
> > +   perl -we '
> > +   use Osstest;
> > +   use Osstest::Executive;
> > +   use DBI;
> > +   csreadconfig();
> > +   print "psql",
> > +        " -d ", $dbh_tests->{pg_db},
> > +        " -h ", $dbh_tests->{pg_host},
> > +        " -p ", $dbh_tests->{pg_port},
> > +        " -U ", $dbh_tests->{pg_user},
> 
> I suppose none of those can (or at least should) contain any weird quote-
> requiring chars etc?

Host and ports definitely can't.  I think if someone makes database
names and usernames with shell metacharacters in they deserve the
resulting pile of debris.

> >  # Good grief, handling background proceesses from shell is a pain.
> 
> I just spotted a typo here "proceesses".

I'll fix that.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel