Re: [Xen-devel] [OSSTEST PATCH 07/11] cri-getconfig: Provide debugging for get_psql_cmd

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 07/11] cri-getconfig: Provide 
debugging for get_psql_cmd"):
> On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> > If set -x is in force, turn it off for get_psql_cmd: our perl rune is
> > uninteresting to see repeated ad infinitum in debugging output.
> 
> I should probably know this, but what is the scope of the set +x here? Is
> it confined to get_psql_cmd or will callers find things going surprisingly
> quiet?

get_psql_cmd is generally used inside $( ), which limits the scope of
the +x.  Code which wraps get_psql_cmd might do some things after
calling it, but not very much.

> Experimentally I think it is the latter, which is a shame. Maybe just wrap
> the set+perl in ()s ?

That would improve things if anyone is likely to redirect
get_psql_cmd into a file, but that seems unlikely.  I'll do that if
you want, though.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel