[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] x86: Fixup IRQs when CPUs go down during shutdown

On 12/10/2015 09:28 AM, Jan Beulich wrote:
On 10.12.15 at 10:21, <ross.lagerwall@xxxxxxxxxx> wrote:
On 12/04/2015 02:42 PM, Jan Beulich wrote:
On 04.12.15 at 15:01, <ross.lagerwall@xxxxxxxxxx> wrote:
Commit fc0c3fa2ad5c ("x86/IO-APIC: fix setup of Xen internally used IRQs
(take 2)") introduced a regression on some hardware where Xen would hang
during shutdown, repeating the following message:
APIC error on CPU0: 08(08), Receive accept error

This appears to be because an interrupt (in this case from the serial
console) destined for a CPU other than the boot CPU is left unhandled so
an APIC error on CPU 0 is generated instead.

To fix this, before taking down the non-boot CPUs, call fixup_irqs()
with a CPU mask of only the boot CPU to reset the IRQ affinities

Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Is this going to go onto staging?

I really was waiting for some kind of response to

... I really would have wanted the split of the functions to be
undone too (renaming the bool_t function parameter suitably).

in the mail that you just replied to (but stripped those parts off).

Oh, given the Reviewed-by tag, I thought you weren't expecting a response. Anyway, I prefer the version split into two functions since it is doing two logically separate tasks. I prefer having (arguably) better code than having less code churn and a smaller patch size.

Ross Lagerwall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.