Re: [Xen-devel] [PATCH v10 1/9] xen/x86: set the vPMU interface based on the presence of a lapic

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.15 at 08:51, <kevin.tian@xxxxxxxxx> wrote:
>>  From: Roger Pau Monne
>> Sent: Tuesday, December 08, 2015 12:48 AM
>> 
>> Instead of choosing the interface to expose to guests based on the guest
>> type, do it based on whether the guest has an emulated local apic or not.
>> 
>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
> 
> [...]
> 
>> @@ -637,7 +638,7 @@ long do_xenpmu_op(unsigned int op,
>> XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg)
>>      struct xen_pmu_data *xenpmu_data;
>>      struct vpmu_struct *vpmu;
>> 
>> -    if ( !opt_vpmu_enabled )
>> +    if ( !opt_vpmu_enabled || has_vlapic(current->domain) )
>>          return -EOPNOTSUPP;
> 
> !has_vlapic(current->domain)?

Definitely not - a guest with vLAPIC shouldn't use the hypercall.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel