Re: [Xen-devel] [PATCH v7 25/28] build: convert HAS_MEM_PAGING use to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.15 at 13:57, <cardoe@xxxxxxxxxx> wrote:
> On 12/11/15 4:52 AM, Jan Beulich wrote:
>>>>> On 10.12.15 at 17:48, <cardoe@xxxxxxxxxx> wrote:
>>> --- a/config/x86_32.mk
>>> +++ b/config/x86_32.mk
>>> @@ -6,7 +6,6 @@ CONFIG_MIGRATE := y
>>>  CONFIG_XCUTILS := y
>>>  
>>>  HAS_MEM_ACCESS := y
>>> -HAS_MEM_PAGING := y
>>>  HAS_MEM_SHARING := y
>>>  
>>>  CFLAGS += -m32 -march=i686
>>> --- a/config/x86_64.mk
>>> +++ b/config/x86_64.mk
>>> @@ -7,7 +7,6 @@ CONFIG_MIGRATE := y
>>>  CONFIG_XCUTILS := y
>>>  
>>>  HAS_MEM_ACCESS := y
>>> -HAS_MEM_PAGING := y
>>>  HAS_MEM_SHARING := y
>>>  
>>>  CONFIG_XEN_INSTALL_SUFFIX := .gz
>> 
>> I'm sure I gave this comment before: Considering that the previous
>> patch converted HAS_MEM_ACCESS, the patch context here shows
>> that this was an incomplete conversion.
> 
> That's not the case. HAS_MEM_ACCESS is used in the tools/ directory
> currently as well so it has to remain here for now. I was going to look
> at what changes could be made there after this series. Likely it'll be
> turned on always in the tools stack and just gracefully handle the fact
> that the hypervisor might have it disabled.

All targets currently set HAS_MEM_ACCESS, so that single use in
tools/ could be converted to just y.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel