Re: [Xen-devel] [PATCH XEN v6 10/32] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-12-03 at 11:22 +0000, Ian Campbell wrote:
> [...]
> +void *xengnttab_map_grant_ref(xengnttab_handle *xgt,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuint32_t domid,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuint32_t ref,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂint prot);
> [...]
> +int xengnttab_munmap(xengnttab_handle *xgt,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂvoid *start_address,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂuint32_t count);

The use of munmap here is a bit inconsistent, it's not xengnttab_mmap and
xenforeignmemory is just unmap, so I think I'll change this
s/munmap/unmap/.

> [...]
> +void *xengntshr_share_pages(xengntshr_handle *xgs, uint32_t domid,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂint count, uint32_t *refs, int writable);
> +
> [...]
> +int xengntshr_munmap(xengntshr_handle *xgs, void *start_address, uint32_t 
> count);

For this one I think unshare would be a better name as a counterpart to
xengntshr_share_*.

I don't think these changes should invalidate any existing review/ack, but
I thought I would mention it up front.

Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel