Re: [Xen-devel] [PATCH] tools/symbols: document binutils commits for issues needing workarounds so far

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-12-16 at 00:53 -0700, Jan Beulich wrote:
> Also the issue 3rd issue mentioned in commit d37d63d4b5 ("symbols:
> prefix static symbols with their source file names") has been fixed by
> binutils commit 270f824531 (also expected to appear in 2.27).
> 


> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


> --- a/xen/tools/symbols.c
> +++ b/xen/tools/symbols.c
> @@ -105,15 +105,18 @@ static int read_symbol(FILE *in, struct
> Â
> Â     sym = strrchr(str, '.');
> Â     if (strcasecmp(type, "FILE") == 0 ||
> -     ÂÂÂÂ(/* GNU nm prior to XXX doesn't produce a type for EFI
> binaries. */
> +     ÂÂÂÂ(/*
> +     ÂÂÂÂÂÂ* GNU nm prior to binutils commit 552e55ed06 (expected to
> +     ÂÂÂÂÂÂ* appear in 2.27) doesn't produce a type for EFI binaries.
> +     ÂÂÂÂÂÂ*/
> Â     ÂÂÂÂÂinput_format == fmt_sysv && !*type && stype == '?' && sym
> &&
> Â     ÂÂÂÂÂsym[1] && strchr("cSsoh", sym[1]) && !sym[2])) {
> Â             /*
> -             Â* gas prior to XXX outputs symbol table entries
> resulting
> -             Â* from .file in reverse order. If we get two
> consecutive file
> -             Â* symbols, prefer the first one if that names an object
> file
> -             Â* or has a directory component (to cover multiply
> compiled
> -             Â* files).
> +             Â* gas prior to binutils commit fbdf9406b0 (expected to
> appear
> +             Â* in 2.27) outputs symbol table entries resulting from
> .file
> +             Â* in reverse order. If we get two consecutive file
> symbols,
> +             Â* prefer the first one if that names an object file or
> has a
> +             Â* directory component (to cover multiply compiled
> files).
> Â             Â*/
> Â             bool multi = strchr(str, '/') || (sym && sym[1] == 'o');
> Â
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel