[Xen-devel] [PATCH] x86: Make printks consistent in hvm_set_callback_via function

[Malcolm Crossley <malcolm.crossley@xxxxxxxxxx>]

The printks in the switch statement do not match the dprintk used
immediately before the switch statement. This leads to confusing messages
being printed to the Xen console log on non-debug versions of Xen.
---
 xen/arch/x86/hvm/irq.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c
index 0f3ab6c..654e533 100644
--- a/xen/arch/x86/hvm/irq.c
+++ b/xen/arch/x86/hvm/irq.c
@@ -390,16 +390,17 @@ void hvm_set_callback_via(struct domain *d, uint64_t via)
     switch ( via_type )
     {
     case HVMIRQ_callback_gsi:
-        printk("GSI %u\n", gsi);
+        dprintk(XENLOG_G_INFO, "GSI %u\n", gsi);
         break;
     case HVMIRQ_callback_pci_intx:
-        printk("PCI INTx Dev 0x%02x Int%c\n", pdev, 'A' + pintx);
+        dprintk(XENLOG_G_INFO, "PCI INTx Dev 0x%02x Int%c\n", pdev,
+                'A' + pintx);
         break;
     case HVMIRQ_callback_vector:
-        printk("Direct Vector 0x%02x\n", (uint8_t)via);
+        dprintk(XENLOG_G_INFO, "Direct Vector 0x%02x\n", (uint8_t)via);
         break;
     default:
-        printk("None\n");
+        dprintk(XENLOG_G_INFO, "None\n");
         break;
     }
 }
-- 
1.7.12.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel