Re: [Xen-devel] [PATCH v4 4/5] xl: Return an error on failed cd-insert

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2015-12-18 at 12:23 +0000, George Dunlap wrote:
> This makes xl more useful in scripts.
> 
> The strange thing about this is that the internal cd_insert function
> *already* returned something appropriate, and cd-eject was using it,
> but cd-insert wasn't.
> 
> Also:
> 
> * Rework cd_insert to return EXIT_FAILURE and EXIT_SUCCESS rather
> than
> magic constants
> 
> * Use 'r' for non-libxl return code, as specified in CODING_STYLE
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>
Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel