Re: [Xen-devel] [PATCH] build: save generated config in /boot

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.12.15 at 13:45, <cardoe@xxxxxxxxxx> wrote:
> On 12/21/15 6:53 AM, Jan Beulich wrote:
>>>>> On 21.12.15 at 13:40, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 21/12/15 12:11, Jan Beulich wrote:
>>>>>>> On 18.12.15 at 22:35, <cardoe@xxxxxxxxxx> wrote:
>>>>> Since we now support changing Xen options with Kconfig, we should save
>>>>> the configuration that was used to build up Xen. This will save it in
>>>>> /boot alongside the installed xen.gz and call it
>>>>> xen-$(FULLVERSION).config
>>>>>
>>>>> Suggested-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>>>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>>>>> ---
>>>>>  xen/Makefile | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/xen/Makefile b/xen/Makefile
>>>>> index 9023863..460b977 100644
>>>>> --- a/xen/Makefile
>>>>> +++ b/xen/Makefile
>>>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>>>>>   ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z)
>>>>>   [ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)
>>>>>   $(INSTALL_DATA) $(TARGET)-syms 
>>>>> $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION)
>>>>> + $(INSTALL_DATA) $(KCONFIG_CONFIG) 
>>> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config
>>>> Was it really suggested to put this into /boot? It has no business
>>>> being there...
>>>
>>> A typical Linux has:
>>>
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ ls -lA /boot/
>>> total 21044
>>> -rw-r--r--  1 root root   157726 Dec 15 15:40 config-3.16.0-4-amd64
>>> drwxr-xr-x  5 root root     4096 Dec 18 07:53 grub
>>> -rw-r--r--  1 root root 15535038 Dec 18 07:52 initrd.img-3.16.0-4-amd64
>>> drwx------  2 root root    16384 Oct 19 11:11 lost+found
>>> -rw-r--r--  1 root root  2676277 Dec 15 15:40 System.map-3.16.0-4-amd64
>>> -rw-r--r--  1 root root  3118928 Dec 15 15:37 vmlinuz-3.16.0-4-amd64
>>>
>>> which at the very least is consistent between Debian and RHEL derivatives.
>>>
>>> IMO, doing the same for Xen is sensible.
>> 
>> I'm afraid I have to disagree - just because Linux does things a
>> certain way doesn't mean that the only (sensible) way. Imo /boot
>> should hold exclusively stuff needed for booting. Remember how
>> we moved xen-syms out of there not so long ago? You could have
>> objected to that change too, considering that Linux puts
>> System.map and sometimes also the uncompressed vmlinux there.
>> Yet I think it was a correct move, and the change here should
>> follow that model instead of Linux'es.
> 
> I don't think you're correct here Jan. Looking at most distros I have at
> hand (I'll admit I don't have SuSE available to me). The uncompressed
> kernel is not in /boot.

Note how I said "sometimes"? And I suppose you will agree that
System.map is unnecessary for booting, despite it getting put in
/boot quite commonly as it looks.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel