Re: [Xen-devel] [OSSTEST PATCH] support XSM/FLASK via Kconfig

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-12-22 at 13:00 -0600, Doug Goldstein wrote:
> In antcipation of XSM and FLASK migrating to Kconfig add support for
> building them via Kconfig or the existing mechanism.
> 
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> ---
> I have not tested this because I'm honestly not sure and I'm not sure if
> this is correct. I'm just trying to write something to prevent a failure
> once XSM/FLASK gets changed to Kconfig and education for myself on how
> to do these patches in the future.

The general shape looks plausible, but it needs to continue working even
with Xen 4.6 and older.

Not sure how best to achieve that, perhaps checking for the existence of
some well known piece of the Kconfig infrastructure and behaving
accordingly?

Another alternative would be to add a runvar (see osstest.git/README for
the terminology) which controls whether Kconfig is to be used expected, but
given that this is static and per branch I'm not sure there is too much
point in this case (and it would be more complex for a newcomer).

Ian J probably has an opinion.

> ---
> Âts-xen-build | 3 +++
> Â1 file changed, 3 insertions(+)
> 
> diff --git a/ts-xen-build b/ts-xen-build
> index 80b1faa..6616ed3 100755
> --- a/ts-xen-build
> +++ b/ts-xen-build
> @@ -55,6 +55,8 @@ sub checkout () {
> Â     echo >>.config KERNELS=''
> ÂEND
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(nonempty($r{enable_xsm}) ? <<END : '').
> +     echo >>xen/.config CONFIG_XSM='${build_xsm}'
> +     echo >>xen/.config CONFIG_FLASK='${build_xsm}'
> Â     echo >>.config XSM_ENABLE='${build_xsm}'
> ÂEND
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(nonempty($r{tree_qemu}) ? <<END : '').
> @@ -126,6 +128,7 @@ END
> ÂEND
> Â#/;
> ÂÂÂÂÂbuildcmd_stamped_logged(9000, 'build', '',<<END,'');
> +ÂÂÂÂÂÂÂÂÂÂÂÂ$make_prefix make -C xen olddefconfig
> ÂÂÂÂÂÂÂÂÂÂÂÂÂ$make_prefix make $makeflags @ARGV
> ÂEND
> Â

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel