[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself for kconfig

>>> On 06.01.16 at 15:26, <tim@xxxxxxx> wrote:
> At 06:45 -0700 on 06 Jan (1452062722), Jan Beulich wrote:
>> >>> On 05.01.16 at 13:07, <ian.campbell@xxxxxxxxxx> wrote:
>> > On Wed, 2015-12-16 at 08:41 -0600, Doug Goldstein wrote:
>> >> Added myself as the maintainer of kconfig.
>> >> 
>> >> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> >> CC: Jan Beulich <jbeulich@xxxxxxxx>
>> >> CC: Keir Fraser <keir@xxxxxxx>
>> >> CC: Tim Deegan <tim@xxxxxxx>
>> >> 
>> >> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>> > 
>> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> Which reminds me that I meant to reply before the holidays,
>> but then didn't get around to.
>> To be honest, I'm not convinced. On one hand I'm certainly
>> happy for this to not fall under THE REST, but on the other
>> hand I've checked your, Doug, history on both Xen and Linux
>> without finding (on the Linux side) any Kconfig related
>> contribution, and only few earlier ones on either side. I hope
>> you understand that I'm uncertain about a relative newcomer
>> to be immediately granted maintainership over a non-negligible
>> (both in terms of size and functionality) piece of code.
> The usual failure mode for Xen contributors is that they leave the
> code and never follow up; this is a strong sign that Doug is going to
> stick around, and IMO ought to be encouraged!  And in any case Xen as
> a whole has a chronic lack of reviewer bandwidth which will only be
> fixed by welcoming new reviewers.

True, except anyone can be reviewer, not just maintainers.

> If you feel like he may need some shepherding in the short term, maybe
> someone more experienced could be co-maintainer for a bit?

Shepherding isn't the problem, nor would a co-maintainer solve
it (after all any maintainer can approve changes). What I'd like
to see before granting maintainership is some meaningful amount
of (own, i.e. not just pulled over) contributions as well as reviews.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.