Re: [Xen-devel] [PATCH v2 02/13] libxc: support new xenstore domain flag in libxc

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
> Support the xenstore domain flag for obtaining domain info.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Âtools/libxc/include/xenctrl.h |ÂÂ2 +-
> Âtools/libxc/xc_domain.cÂÂÂÂÂÂÂ| 17 +++++++++--------
> Â2 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/libxc/include/xenctrl.h
> b/tools/libxc/include/xenctrl.h
> index 01a6dda..45d8ff6 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -456,7 +456,7 @@ typedef struct xc_dominfo {
> ÂÂÂÂÂuint32_tÂÂÂÂÂÂssidref;
> ÂÂÂÂÂunsigned intÂÂdying:1, crashed:1, shutdown:1,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂpaused:1, blocked:1, running:1,
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂhvm:1, debugged:1, pvh:1;
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂhvm:1, debugged:1, pvh:1, xs_domain:1;

All the other flags omit the _domain/_guest since it is implicit in the
context I think.

"xs" would be ok, so would "xenstore" or "xenstored" I think.

You might want to consider similar arguments for DOMINF and the create
flag, or you might want to argue that this field should be xs_domain for
consistency with those.

Apart from what colour to paint the shed to code looks trivially correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel