Re: [Xen-devel] [PATCH v2 2/3] XENVER_build_id: Provide ld-embedded build-ids

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Nov 10, 2015 at 09:49:00AM -0700, Jan Beulich wrote:
> >>> On 06.11.15 at 20:36, <konrad.wilk@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -109,15 +109,19 @@ $(TARGET)-syms: prelink.o xen.lds 
> > $(BASEDIR)/common/symbols-dummy.o
> >     $(NM) -pa --format=sysv $(@D)/.$(@F).0 \
> >             | $(BASEDIR)/tools/symbols --sysv --sort >$(@D)/.$(@F).0.S
> >     $(MAKE) -f $(BASEDIR)/Rules.mk $(@D)/.$(@F).0.o
> > -   $(LD) $(LDFLAGS) -T xen.lds -N prelink.o \
> > +   $(LD) $(LDFLAGS) -T xen.lds -N prelink.o --build-id=sha1 \
> 
> You continue to use option this unconditionally.

I presume you are suggesting that I should check that the $(LD) can use this 
right?

I've been building this using an ancient tool-chain:
GNU ld version 2.20.51.0.2-20.fc13 20091009

And even there it is OK.

Or are you thinking of a different LD altogether and checking for that?

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel