Re: [Xen-devel] [PATCH] arch/x86: convert bigmem to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 1/8/16 2:50 AM, Jan Beulich wrote:
>>>> On 08.01.16 at 03:55, <cardoe@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -25,6 +25,18 @@ config ARCH_DEFCONFIG
>>  
>>  menu "Architecture Features"
>>  
>> +config BIGMEM
>> +    bool "big memory support"
>> +    default n
>> +    ---help---
>> +      Allows Xen to support up to 123Tb of memory.
>> +
>> +      This requires growing struct page_info from 32 to 48 bytes as well
>> +      as shrinking the always accessible direct mapped memory range from
>> +      5Tb to 3.5Tb.
> 
> Fundamentally okay, but I think the numbers should be dropped
> (as they could easily become stale, since they reflect in the first
> case just current state and in the second really just an
> implementation detail). No strict need to re-submit (can be fixed
> up upon commit), but I'd like to have your consent since this is
> going to be under your name.
> 
> Jan
> 

Yes that's fine. I just copied the original commit message that added
big mem support. I'm actually hoping that more people do what you're
proposing and provide better detailed messages when they understand how
that code works. So thank you!

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel