Re: [Xen-devel] [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2016-01-08 at 14:45 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm
> xs control path"):
> > On Fri, 2016-01-08 at 14:12 +0000, Ian Jackson wrote:
> > > Â * In xenstore we record which qemus a domain has.ÂÂThis is
> > > necessary
> > > Â * for correct teardown.ÂÂAnd, we also record whether the xenstore
> > > Â * paths are unified, as discussed above, so that subsequent libxl
> > > Â * operations can do the right thing.ÂÂThis is what the EMUID_SPLIT
> > > Â * flag is for.
> > 
> > EMUID_SPLIT actually records the inverse (i.e. that they are split,
> > rather
> > than unified as the previous text is discussing).
> > 
> > I knew what you meant though, and clarifying it could well make it less
> > obvious I suspect.
> 
> Yes.ÂÂI could explain the reason for the sense of the flag, which is
> to get the default right, but that seems obvious.
> 
> How about:
> 
> > > Â * In xenstore we record which qemus a domain has.ÂÂThis is
> > > Â * necessary for correct teardown.ÂÂAnd, we also record whether
> > > Â * the xenstore paths are split or unified, as discussed above,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ++++++++
> > > Â * so that subsequent libxl operations can do the right
> > > Â * thing.ÂÂThis is what the EMUID_SPLIT flag is for.
> 
> ?

Looks good, thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel