[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig

To: "Doug Goldstein" <cardoe@xxxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Mon, 11 Jan 2016 07:24:12 -0700
Cc: Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>, Dario Faggioli <dario.faggioli@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Mon, 11 Jan 2016 14:24:33 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>> On 09.01.16 at 00:17, <cardoe@xxxxxxxxxx> wrote:
> This converts the usage of NR_CPUS / MAX_PHYS_CPUS to Kconfig as
> CONFIG_NR_CPUS.

Considering the size of the patch, the doubling of the identifier's
length, and the fact that even Linux continues to use NR_CPUS
I wonder whether we wouldn't be better of simply having

#define NR_CPUS CONFIG_NR_CPUS

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig
  - From: Doug Goldstein

References:
- [Xen-devel] [PATCH 1/2] build: introduce CONFIG_NR_CPUS in Kconfig
  - From: Doug Goldstein
- [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig
  - From: Doug Goldstein

Prev by Date: Re: [Xen-devel] [PATCH] xen/spinlock: Use mnemonics for recursive spinlock sentinel values
Next by Date: [Xen-devel] [qemu-upstream-4.6-testing test] 77722: tolerable FAIL - PUSHED
Previous by thread: Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig
Next by thread: Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.