Re: [Xen-devel] [PATCH 1/5] xen/elfnotes: initialise phys_entry to UNSET_ADDR32

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.16 at 13:52, <roger.pau@xxxxxxxxxx> wrote:
> El 13/01/16 a les 13.46, Jan Beulich ha escrit:
>>>>> On 13.01.16 at 13:32, <roger.pau@xxxxxxxxxx> wrote:
>> 
>> Re the title: I think the fix here really is to the checking against the
>> right value, not the initialization?
> 
> Yes, the initialization doesn't matter much, the proper fix is the
> checking. I would change it to:
> 
> xen/elfnotes: check phys_entry against UNSET_ADDR32
> 
> Which I think can be done by the committer (or I can resend if needed).

Sure.

>>>  tools/libxc/xc_dom_elfloader.c     | 2 +-
>>>  xen/common/libelf/libelf-dominfo.c | 1 +
>>>  xen/include/xen/libelf.h           | 1 +
>>>  3 files changed, 3 insertions(+), 1 deletion(-)
>> 
>> With this diffstat, any reason only tools maintainers got Cc-ed?
> 
> Hm, weird, that's what scripts/get_maintainer.pl gave me as output.

Something must be broken there.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel