Re: [Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.16 at 13:32, <roger.pau@xxxxxxxxxx> wrote:
> The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the
> initial state, which is called from the toolstack during domain creation.

But the comment that you remove says explicitly that this isn't a
requirement.

Jan

> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/hvm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 787b7de..05c3ca1 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2474,10 +2474,6 @@ int hvm_vcpu_initialise(struct vcpu *v)
>   
>          /* Init guest TSC to start from zero. */
>          hvm_set_guest_tsc(v, 0);
> -
> -        /* Can start up without SIPI-SIPI or setvcpucontext domctl. */
> -        v->is_initialised = 1;
> -        clear_bit(_VPF_down, &v->pause_flags);
>      }
>  
>      return 0;
> -- 
> 1.9.5 (Apple Git-50.3)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel