Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, Jan 14, 2016 at 5:41 AM, Chun Yan Liu <cyliu@xxxxxxxx> wrote:
>> > +static int sysfs_write_intf(libxl__gc *gc, const char *intf, const char
>> *path)
>> > +{
>>
>> What is `intf' here ?  Maybe `interface' ?  But there is nothing usb
>> specific about this function.  Looking for similar code elsewhere this
>> function seems very similar to libxl_pci.c:sysfs_write_bdf, but I
>> won't ask you to try to refactor these two functions together.
>
> Yes, it means 'interface'. It is referring to old xend/xm naming.
> For example, a USB device in Linux sysfs is 3-11, under it, there might be
> 3-11:1.0 and 3-11:1.1 (these are two interfaces). To assign this USB device
> to guest, both 3-11:1.0 and 3-11:1.1 should be unbind from original driver
> and bind to usbback.

Just to be clear, "intf" is the old xend/xm naming; but "interface" is
part of the USB topology description.  One USB device can have several
interfaces, just like one PCI device can have several 'functions', so
the comparison to sysfs_write_bdf() is apt.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel