Re: [Xen-devel] [PATCH v5 2/5] build: Hook the schedulers into Kconfig

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2016-01-14 at 09:44 -0700, Jan Beulich wrote:
> > > > On 14.01.16 at 17:34, <ian.campbell@xxxxxxxxxx> wrote:
> > On Thu, 2016-01-14 at 10:23 -0600, Jonathan Creekmore wrote:
> > > Jan Beulich writes:
> > > 
> > > > > > > On 14.01.16 at 15:49, <jonathan.creekmore@xxxxxxxxx> wrote:
> > > > > --- a/xen/common/Kconfig
> > > > > +++ b/xen/common/Kconfig
> > > > > @@ -51,4 +51,63 @@ config KEXEC
> > > > > 
> > > > > Â     ÂÂIf unsure, say Y.
> > > > > 
> > > > > +# Enable schedulers
> > > > > +menu "Schedulers"
> > > > > +     visible if EXPERT = "y"
> > > > > +
> > > > > +config SCHED_CREDIT
> > > > > +     bool
> > > > > +     default y
> > > > > +     ---help---
> > > > > +     ÂÂThe traditional credit scheduler is a general purpose
> > > > > scheduler.
> > > > 
> > > > So is this option now useful for anything?
> > > 
> > > It keeps the code between all of the schedulers consistent (all of
> > > them
> > > have a #define if they are compiled it)
> > 
> > FWIW I think this (consistency) is a reasonable argument for having
> > this
> > option even if it doesn't actually do anything.
> 
> While I can see your point, I dislike useless clutter in .config (also
> on Linux, where I every once in a while send some cleanup
> patches).

I don't think this one is useless clutter, it provides useful information
to someone looking at the .config rather than then having to go and check
the source to find out what the defaults were.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel