[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1] xen/arm: Add r1p12 to the list of supported Cadence UARTs

On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>

Where are the bindings forÂcdns,uart-r1p12 defined? I don't see it
mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt in
mainline Linux.

Does the driver need to differ at all compared with what is needed for
r1p8? Normally if there is no (practical/visible) difference then in DT-
world there is no need for a new compatible string, since the device is
still compatible.

If there are differences in the h/w but they are not relevant to our
particular driven then please say so in the commit log.


> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>
> ---
> Âxen/drivers/char/cadence-uart.c | 1 +
> Â1 file changed, 1 insertion(+)
> diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-
> uart.c
> index 933672f..7f90f8d 100644
> --- a/xen/drivers/char/cadence-uart.c
> +++ b/xen/drivers/char/cadence-uart.c
> @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node
> *dev, const void *data)
> Âstatic const struct dt_device_match cuart_dt_match[] __initconst =
> Â{
> ÂÂÂÂÂDT_MATCH_COMPATIBLE("cdns,uart-r1p8"),
> +ÂÂÂÂDT_MATCH_COMPATIBLE("cdns,uart-r1p12"),
> ÂÂÂÂÂ{ /* sentinel */ },
> Â};
> Â

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.