[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 1/5] build: Env var to enable expert config options



>>> On 15.01.16 at 16:47, <ian.campbell@xxxxxxxxxx> wrote:
> On Thu, 2016-01-14 at 09:09 -0700, Jan Beulich wrote:
>> > > > On 14.01.16 at 15:49, <jonathan.creekmore@xxxxxxxxx> wrote:
>> > --- a/xen/Kconfig
>> > +++ b/xen/Kconfig
>> > @@ -22,3 +22,7 @@ config DEFCONFIG_LIST
>> >    string
>> >    option defconfig_list
>> >    default "$ARCH_DEFCONFIG"
>> > +
>> > +config EXPERT
>> > +  string
>> > +  option env="XEN_CONFIG_EXPERT"
>> 
>> This better wouldn't go in ahead of
>> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01321.html 
>> and would then need adjustment to take care of avoiding
>> re-introduction of that same problem.
> 
> I don't follow what problem would be reintroduced, this patch seems to be
> correctly defining and exporting XEN_CONFIG_EXPERT from xen/Makefile before
> any inclusion of kconfig related things

Ah, wait, this variable comes from the environment in the first place,
and hence should be visible to Makefile.kconfig no matter what. I'm
sorry for the noise then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.